Michael Orlov

Results 271 comments of Michael Orlov

However we are not handling medata.version properly when trying to read out metadata from database directly.

@amacneil I agree it would be nice if all metadata information from `metadata.yaml` file would be duplicated in db3 file directly. But currently it is not. We have an issue...

Now rolling and humble support reading Eloquent bags.

@amacneil As regards > It will help when we need to do things like guess which version of the message definitions to use. Can you please clarify how dds middleware...

@amacneil Thanks a lot for the clarification. I am open to consider to store `ROS_DISTRO` if it will be really helpful. Let's discuss, consider some details. - I had a...

@defunctzombie Good point. We might be able to add ROS_DISTRO as extra field when doing changes in the scope of the #1108. We need to make backward comparability any way...

@amacneil I think you are right that `we would not be able to backport db3 schemas to Humble because it would require breaking ABI compatibility`. Will try to add ROS_DISTRO...

@wkalt @amacneil Can we count this issue as resolved since I've added `ROS_DISTRO` to the new `schema_version` table and corresponding API `std::string SqliteStorage::get_recorded_ros_distro() const` in SQLite3 plugin as part of...