Michaël De Boey

Results 478 comments of Michaël De Boey

@julienw The scenario you're describing sounds indeed like a good use case for using [`within`](https://testing-library.com/docs/dom-testing-library/api-within) instead.

> I guess we can ignore those function named following PascalCase so we assume they are components? That could already be a start I think.

@styfle that's correct, but that file is also only used when using TypeScript, right? If that's correct, this means that people who don't need that functionality (because they're not using...

I still think `typescript` should be in `peerDependencies` instead of normal `dependencies` though, as now you're causing a possible double installation of the package by having a strict version in...

> should I make the changes in this PR or create a new one? @talohana You can just hard reset this branch onto `upstream/master` and push new commits

@xdebbie Adding support for Tidal seems like a good one to me, accepting PRs if you want to give it a go 🙂

Hey @teeaarbee! 👋 Can you elaborate a bit more about the problem please? Can you provide a reproduction repo and some screenshots about the things you think aren't working?

@jlengstorf's usage of vimeo embeds https://github.com/jlengstorf/lengstorf.com/search?q=vimeo&unscoped_q=vimeo

@acagastya Added a trailing slash and it works now 🙂

I've sent them a tweet to ask for an oembed endpoint without needing an API key 🙂 https://twitter.com/MichaelDeBoey93/status/1264559548599328768