Michaël De Boey
Michaël De Boey
@bradzacher I've reverted all the changes except for `isNodeOfType` (for now), so we'll have less possible errors
@bradzacher Do you happen to know how I could fix it? I really have no clue tbh 😕
@bradzacher Those changes seem to be fixing the issues indeed https://github.com/typescript-eslint/typescript-eslint/runs/5442617641 I'll update all other helper functions again, so we can see if that was the only problem or not....
@bradzacher It seems that as soon as I try to fix the `Conditions` type, so doing ```ts Conditions extends Partial ``` https://github.com/typescript-eslint/typescript-eslint/runs/5453597206?check_suite_focus=true instead of ```ts Conditions extends Partial ``` https://github.com/typescript-eslint/typescript-eslint/runs/5453547606?check_suite_focus=true...
@Beraliv Seems like changing `ObjectEntry` from ```ts type ObjectEntry = [keyof BaseType, BaseType[keyof BaseType]]; ``` to ```ts type ObjectEntry = BaseType extends unknown ? [keyof BaseType, BaseType[keyof BaseType]] : never;...
@Beraliv Still failing CI apparently. Would be awesome if you could take a look at it.
@Beraliv @farskid Can you point me in the right direction please? Can't seem to figure it out unfortunately 😕
@Inkdpixels @GAntoine I think we also should support `flow` libdefs for non-npm packages, like @zertosh said in [#16 (comment)](https://github.com/flowtype/flow-typed/issues/16#issuecomment-247115391) and addresses things like discussed in #412 & facebook-atom/atom-ide-ui#95 🙂
Adding support for pre-releases, like discussed in #392 would also be something to consider for `v3.0` I think?
@swernerx This plugin is dependent on `eslint4b`, which isn't ESLint v8 compatible yet unfortunately PR is ready (https://github.com/mysticatea/eslint4b/pull/14), but it's blocked by another package of @mysticatea