Michael Courtney

Results 146 comments of Michael Courtney

Ok it's working again. Though the order is a little jumbled. I'm not sure how it determines order. There were 2 problems: ![options](https://user-images.githubusercontent.com/43386669/184386425-f986ec7e-0693-4fc3-a74c-55e0b276aa71.png) The above are not defined in game_rules.focs.py,...

Sigh... Stuffed that up and had to revert and fix it again. Tried to squish the fix for 5 commits into the 1st one by accident... Anyway... Should work outside...

> > The values were type=int when they actually needed to be signed integers. > > I'm not sure what distinction you're making between "int" and "signed integers". I'm saying...

> Did you just change the `float` to `int` or did you also update the default, min, and max values to remove the `.0` part? If you pass it a...

yeah that worked, will change them to int and update

There's also the colonize planet button to consider

> Is there a discussion thread or does this need testing? I don't have an opinion on the balance aspects. https://www.freeorion.org/forum/viewtopic.php?f=15&t=12509

Lacks a proper graphic (its currently on the generic). Fluff and position in the tech tree, etc. could do with a looking over.

The fail is just checksums that need to be changed? Rather then something more serious?

Hopefully that's got it this time. The tech size in the python parser was different, as I'd added a tech. If it fails this time, I'm out of ideas