Smallrobotic

[MichaelCourtney]

https://www.freeorion.org/forum/viewtopic.php?f=15&t=12234https://www.freeorion.org/forum/viewtopic.php?f=15&t=12234

[MichaelCourtney]

Lacks a proper graphic (its currently on the generic). Fluff and position in the tech tree, etc. could do with a looking over.

[MichaelCourtney]

The fail is just checksums that need to be changed? Rather then something more serious?

[geoffthemedio]

The fail is just checksums that need to be changed? Rather then something more serious?

I think so.

[MichaelCourtney]

Hopefully that's got it this time. The tech size in the python parser was different, as I'd added a tech. If it fails this time, I'm out of ideas

[o01eg]

It would be nice if that tech will be written in Python FOCS already. It doesn't have effects so could be simple.

[MichaelCourtney]

It would be nice if that tech will be written in Python FOCS already. It doesn't have effects so could be simple.

I'll take a look at 1 you've already done tomorrow and rewrite it.

[MichaelCourtney]

@o01eg You might need to look over it and see if I've done this right

[o01eg]

Oh, I'm not yet implemented ShipHull token for unlock.

[o01eg]

I've added support for it in #3983.

[o01eg]

@MichaelCourtney I've merged it, token for unlock is UnlockShipHull.

[o01eg]

It's fine now.

[MichaelCourtney]

Well it was till I tried squishing the commits...

[agrrr3]

Well it was till I tried squishing the commits...

? well, you can always git reset --hard 263e1be and start squishing again

[MichaelCourtney]

Ok now I'm confused. It was working, I squished the commits, got a fail message, went out, came home to a green tick and "all checks have passed".

Seems ready?

[agrrr3]

i am a bit confused about the checksums. You added a tech and a hull, and moved NamedReal. So TechManager, ShipHullManager, (very maybe) NamedValueRefManager, (very maybe) ShipDesignManager and (maybe) Encyclopedia checksums should have changed.

But nothing else (e.g. BuildingTypeManager) should have changed checksums.

From test/system/TestChecksum.cpp in master:

    TestCheckSumFromEnv("FO_CHECKSUM_ENCYCLOPEDIA", 1090024, checksums["Encyclopedia"]);
    TestCheckSumFromEnv("FO_CHECKSUM_FIELD", 3780088, checksums["FieldTypeManager"]);
    TestCheckSumFromEnv("FO_CHECKSUM_POLICY", 7303441, checksums["PolicyManager"]);
    TestCheckSumFromEnv("FO_CHECKSUM_SHIP_HULL", 5932838, checksums["ShipHullManager"]);
    TestCheckSumFromEnv("FO_CHECKSUM_SHIP_PART", 1765649, checksums["ShipPartManager"]);
    TestCheckSumFromEnv("FO_CHECKSUM_SHIP_DESIGN", 872567, checksums["PredefinedShipDesignManager"]);
    TestCheckSumFromEnv("FO_CHECKSUM_SPECIES", 181788, checksums["SpeciesManager"]);
    TestCheckSumFromEnv("FO_CHECKSUM_SPECIALS", 9623845, checksums["SpecialsManager"]);
    TestCheckSumFromEnv("FO_CHECKSUM_TECH", 5378437, checksums["TechManager"]);
    TestCheckSumFromEnv("FO_CHECKSUM_NAMED_VALUEREF", 8513318, checksums["NamedValueRefManager"]);

[o01eg]

Test doesn't enforce values here by default.

[MichaelCourtney]

i am a bit confused about the checksums. You added a tech and a hull, and moved NamedReal. So TechManager, ShipHullManager, (very maybe) NamedValueRefManager, (very maybe) ShipDesignManager and (maybe) Encyclopedia checksums should have changed.

My suspicion is that some commits don't trigger all the tests and a bunch of those are commits already in master. For example I'm almost sure Encyclopedia checksums was the added pedia page over here: https://github.com/freeorion/freeorion/pull/3969

Notice how that pull request says "6 checks passed"? This pull request says "19 checks passed"

[agrrr3]

So the theory is that the checksums in master are currently wrong?

[MichaelCourtney]

So the theory is that the checksums in master are currently wrong?

Yes. Though I'm only guessing. It certainly makes more sense for the shipdesign checksum to be the added tentacle on white krakens and the field checksum to be Oberlus's addition of named values in fields.

[geoffthemedio]

If you look in the master test build logs, eg. https://github.com/freeorion/freeorion/runs/7506756131?check_suite_focus=true you can see the checksum test results, eg. https://github.com/freeorion/freeorion/runs/7506756131?check_suite_focus=true#step:13:3931

5: /home/runner/work/freeorion/freeorion/test/system/TestChecksum.cpp:22: error: warning: in "TestChecksum/compare_checksum": FO_CHECKSUM_BUILDING expected 7870370 was 9738579
5: /home/runner/work/freeorion/freeorion/test/system/TestChecksum.cpp:22: error: warning: in "TestChecksum/compare_checksum": FO_CHECKSUM_ENCYCLOPEDIA expected 1090024 was 1099081
5: /home/runner/work/freeorion/freeorion/test/system/TestChecksum.cpp:22: error: warning: in "TestChecksum/compare_checksum": FO_CHECKSUM_FIELD expected 3780088 was 5633722
5: /home/runner/work/freeorion/freeorion/test/system/TestChecksum.cpp:22: error: warning: in "TestChecksum/compare_checksum": FO_CHECKSUM_POLICY expected 7303441 was 7039723
5: /home/runner/work/freeorion/freeorion/test/system/TestChecksum.cpp:22: error: warning: in "TestChecksum/compare_checksum": FO_CHECKSUM_SHIP_HULL expected 5932838 was 5949918
5: /home/runner/work/freeorion/freeorion/test/system/TestChecksum.cpp:22: error: warning: in "TestChecksum/compare_checksum": FO_CHECKSUM_SHIP_PART expected 1765649 was 1778809
5: /home/runner/work/freeorion/freeorion/test/system/TestChecksum.cpp:22: error: warning: in "TestChecksum/compare_checksum": FO_CHECKSUM_SHIP_DESIGN expected 872567 was 873430
5: /home/runner/work/freeorion/freeorion/test/system/TestChecksum.cpp:22: error: warning: in "TestChecksum/compare_checksum": FO_CHECKSUM_SPECIES expected 181788 was 9777257
5: /home/runner/work/freeorion/freeorion/test/system/TestChecksum.cpp:22: error: warning: in "TestChecksum/compare_checksum": FO_CHECKSUM_SPECIALS expected 9623845 was 8161983
5: /home/runner/work/freeorion/freeorion/test/system/TestChecksum.cpp:22: error: warning: in "TestChecksum/compare_checksum": FO_CHECKSUM_TECH expected 5378437 was 9495557
5: /home/runner/work/freeorion/freeorion/test/system/TestChecksum.cpp:22: error: warning: in "TestChecksum/compare_checksum": FO_CHECKSUM_NAMED_VALUEREF expected 8513318 was 2621528

[MichaelCourtney]

If you look in the master test build logs, eg. https://github.com/freeorion/freeorion/runs/7506756131?check_suite_focus=true you can see the checksum test results, eg. https://github.com/freeorion/freeorion/runs/7506756131?check_suite_focus=true#step:13:3931

Thanks Geoff. Anything I should do with this?

[MichaelCourtney]

@TheSilentOne1 - Hi not sure if you have much free time at the moment. Are you able to provide a graphic? It's just using the generic ship for the moment

[geoffthemedio]

Thanks Geoff. Anything I should do with this?

You can update the checksums in your pull request so that it passes them. Not necessary, though.