Michael Chirico comments

Results 797 comments of


                                            Michael Chirico

Unstated pillar version requirement?

Unfortunately that's too noisy -- {devtools} installs way more packages than needed to just run {rlang}'s suite. We are out of date on 20-30 of those packages. It would be...

Unstated pillar version requirement?

OK, I understand. There's not a version requirement, but a requirement {pillar} be available for the tests. This is pretty opaque in the current suite.

Unstated pillar version requirement?

Thanks; see the linked CL

nonportable_path_linter lints gsub("[^0-9\\-]", "", x)

Related: #1356, #468

Switch to with_mocked_bindings for testthat 3.3.0

``` ══ Failed tests ════════════════════════════════════════════════════════════════ ── Failure ('test-extract.R:391:3'): extract fixest objects created with the fixest package ── Expected `tr@se` to be equivalent to `c(0.021, 0.032)`. 1/2 mismatches [1] 0.0322 -...

Add @usage data('diamonds') to vignettes/rd-other.Rmd

Possibly related to {codetools} bug: https://gitlab.com/luke-tierney/codetools/-/issues/8

Handle dot-prefixed names in custom translation

Thanks for rounding it up!