Michael Chirico

Results 798 comments of Michael Chirico

I think probably the best solution is to suggest the user run a {cyclocomp} diagnostic themselves to understand how to proceed... but there is no such helper today! In fact,...

You should use the native pipe placeholder (that's the 4.3.0 reference in the style guide: https://style.tidyverse.org/pipes.html#magrittr): ```r private$hosts private$check_for_duplicate_hosts() |> append(private$hosts, values = _) ``` Note that the lambdas are...

There are _some_ residual cases where {magrittr} `%>%` works that `|>` won't. That's what's covered by the Style guide here though: https://style.tidyverse.org/pipes.html#magrittr > As of R 4.3.0, the base pipe...

Hm, I think I'm happy with the current state of the lint message. - `is()` is meant for S4 objects -- the original test is incorrect (IMO) - We do...

I agree it's a case where some judgment is needed -- an LLM can likely make the right call. Is it possible for the automated fixes to have a hook...

> I don't want my linter to call LLMs That settles it then :) For completeness, I have a prompt-tuned version of this interaction in mind:

I go back & forth on this one a little bit. One reason to leave a NULL regexp is if your error message is produced by another package/system call. Relying...

Thanks Etienne, as mentioned for #2950, I'd prefer to avoid any conflicts. It would be appreciated if you could drop any files here that intersect with other pending PRs.

Duplicate of #1653. That one is self-contained to {rlang}, but this one shows the downstream impacts; I'll let you triage :)

Sounds reasonable. I do worry about risk of false positives -- obviously there is _some_ good use for `installed.packages()`. Would you mind sharing some good examples you find "in the...