Michael Chirico
Michael Chirico
@olivroy that seems like something more appropriate for {lintr} to help with.
Was just musing about the limitations of `expect_match()`'s `all=` signature. - `expect_match(all = FALSE)` is not exactly the clearest way to say `any()` match should pass -- adding `any =`...
Noting for future readers: officially, only `unix/` and `windows/` subdirectories are supported: https://cran.r-project.org/doc/manuals/R-exts.html#Package-subdirectories The R and man subdirectories may contain OS-specific subdirectories named unix or windows. > I still get...
Reproduced: yes, it comes from top-level. Interestingly, it's coming from `roclet_process.roclet_namespace()`: https://github.com/r-lib/roxygen2/blob/9652d15221109917d46768e836eaf55e33c21633/R/namespace.R#L34-L38 where the `blocks` object does not include SVG.R: ```r sapply(blocks, `[[`, 'file') |> unique() # [1] "R/expect-doppelganger.R" #...
I tried simply editing `r_files()` to be recursive: https://github.com/r-lib/roxygen2/blob/9652d15221109917d46768e836eaf55e33c21633/R/package_files.R#L12-L14 But that produces a different error when running `roxygenize()` in {vdiffr}: ```r roxygen2::roxygenize() # ℹ Loading vdiffr # Error in getDLLRegisteredRoutines.DLLInfo(dll,...
TBH I think this is for {styler}, if anything.
~Well, I upgrade my OS (lol) and `pandoc` to 2.9.2.1 and get the same failures. Gonna try to get an even more recent pandoc...~ OK, ran the tests from 3.1.9...
FWIW this is exactly the sort of thing I had in mind for #710
This will be easier after #2135
OK, renaming the milestones now.