Michael Chirico

Results 322 comments of Michael Chirico

I agree with "when in doubt, keep as is" -- I had in mind cases where the style guide is not explicit, but `styler` nevertheless makes changes. The example from...

I see this a lot too and regular favor styler removing it by default . I think of it like trailing_blank_lines_linter for roxygen blocks

+1 to this. Use case: I'd like to replace the `gsub()` kludge used to `...`out the text to the offending call in `lintr::seq_linter()` here: https://github.com/r-lib/lintr/blob/fc6cb377839ffb6862601e72c0e1b86f7ef00015/R/seq_linter.R#L31 (i.e., it maps `1:length(x)` :arrow_right:...

Friendly bump here -- are the maintainers interested in this?

> The abbreviated names should also be supported. this is done with `pmatch()`: ``` for (abbr in lubridate:::.get_locale_regs()$wday_names$abr) writeLines(format(round_date(ct, "week", week_start = abbr), "%a/%A")) Sun/Sunday Mon/Monday Tue/Tuesday Wed/Wednesday Thu/Thursday Fri/Friday...

Sounds excellent! It would be a miracle if all the data came in perfectly clean. Hopefully you get some crowd-sourced help tracking down issues. Publishing that sort of notebook could...

Nevermind, I think I may have been mis-reading this section. It's saying "You don't have to split a one-call pipe into two lines if it fits in one line, but...

> I'm pretty sure I prefer `(a + b) / (c + d)` to `(a + b)/(c + d)`, so maybe this only applies to simple fractions? I agree with...

Definitely think there are a lot of cases where arguments belong on the same line together (paste is the simplest example), but I agree that bumping everything to the next...