Michael Chirico

sure... I'll rely on your judgement for which class the method should be for, exactly, WDYT? On Thu, Sep 8, 2022, 11:42 PM Maximilian Girlich ***@***.***> wrote: > Probably makes...

We already have this translated internally, as well as `startsWith()` and `endsWith()`. It looks roughly like: ```r #' Escape specials in input to SQL 'LIKE' clauses. #' @noRd # TODO:...

Feel free to assign me... I'll get to it... sometime soon 😄

Looks fine to me :)

Alternatively we might try something like `expect_shape(x, .)` with signature ``` expect_shape = function(x, dim, length, nrow, ncol) {} ``` And `dim` can be fudged to work as `length` for...

SGTM! I'll work on a PR. If it's possible to assign to me, feel free to do so.

As noted at https://github.com/r-lib/vctrs/issues/1470, we _could_ re-use `expect_vector()` in some cases: ``` testthat::expect_vector(matrix(1:10, 2, 5), ptype = rbind(integer(5)), size = 2L) ``` But that's pretty abstruse IMO; the proposed `expect_shape()`...

I was thinking to let the allowed chars be configurable. that way it covers roxygen comments, but also any other meta commenting systems that might be out there. by default...

yep so ``` foo() # c1 double_foo() #c2 ``` will lint on c2

that sounds right. my first reaction was that subsequent lines should match the same repetition but that would preclude decorative comments like ``` ########### # comment # ########### ``` (although,...