actions icon indicating copy to clipboard operation
actions copied to clipboard

Add GHA for linting only the changes files

Open IndrajeetPatil opened this issue 1 year ago • 3 comments

Closes #567

Changes from current version in {lintr}:

  • Builds fail if any additional lints are found (which should also be the case in {lintr} once https://github.com/r-lib/lintr/pull/1522 is merged).
  • Uses the .lintr file to find lintr settings instead of .lintr_new, which is something {lintr}-specific.

cc @MichaelChirico Do you see anything else that should be modified for general usage?

IndrajeetPatil avatar Sep 12 '22 11:09 IndrajeetPatil

Codecov Report

Merging #620 (6f32ec2) into v2-branch (7dbac86) will not change coverage. The diff coverage is n/a.

@@             Coverage Diff             @@
##           v2-branch      #620   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
===========================================
  Files              2         2           
  Lines             10        10           
===========================================
  Hits              10        10           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Sep 12 '22 11:09 codecov-commenter

Looks fine to me :)

MichaelChirico avatar Sep 25 '22 04:09 MichaelChirico

@gaborcsardi Let me know if you need me to make any other changes here. Thanks.

IndrajeetPatil avatar Sep 25 '22 07:09 IndrajeetPatil

Thanks! I am going to merge this now, but in the future we might move it to a different directory or repository, together with other "contributed" workflow examples, to make it clear that this does not have level of testing and support.

gaborcsardi avatar Oct 19 '22 11:10 gaborcsardi

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this pull request.

github-actions[bot] avatar Nov 04 '22 13:11 github-actions[bot]