Michael

Results 9 comments of Michael

Hi, I started working on this, i'm adding a new popup with a scrollbar for the tag annotation instead of using MsgPopup. should have a PR up soon :)

Because currently the annotation is shown using: ``` fn show_annotation(&self) { if let Some(tag) = self.selected_tag() { if let Some(annotation) = &tag.annotation { self.queue.push(InternalEvent::ShowInfoMsg( annotation.clone(), )); } } } ```...

I want to choose the solution that's best for the project and keeps things consistent. Would you recommend adding a scrollbar to the MsgPopup, creating a new popup for tag...

Making a reusable component that is used in `MsgPopup` and `DetailsComponent` sounds good. I can make the change in a single PR or split into 2 (make the `MsgPopup` scrollable...

> @MichaelAug for more instant exchange amongst contributors feel free to join our discord: https://discord.gg/d2p2NS7m Thanks i'm already in the Discord :+1:

I made a PR for the first part. After this is approved I'll make another PR to refactor `MsgPopup` and `DetailsComponent` to use a new `ScrollableTextView` component

Looks like we could use ratatui's built in [Scrollbar widget](https://docs.rs/ratatui/latest/ratatui/widgets/struct.Scrollbar.html) instead of our custom one. This could simplify [scroll_vertical.rs](https://github.com/extrawurst/gitui/blob/master/src/components/utils/scroll_vertical.rs) and [scroll_horizontal.rs](https://github.com/extrawurst/gitui/blob/master/src/components/utils/scroll_horizontal.rs) and probably remove [scrollbar.rs](https://github.com/extrawurst/gitui/blob/master/src/ui/scrollbar.rs) entirely. Would you like this...

> I havent looked into the impact of this but i am all for simplifying and using a upstream solution where we can if it does not degrade performance I...

I've made a small PR to test the scrollbar. You can see the new scrollbar in e.g. tag description or the file list. Looks like a lot of scrollable components...