Micha Reiser
Micha Reiser
I'm planning to pick this up again. This should now be easier with https://github.com/astral-sh/ruff/pull/22083
Okay, I'm close but there's one more challenge here and that is that we need to recompute the file's diagnostics after adding the suppressions or all offsets will be off...
Thanks for opening this rule idea. The main challenge with this rule is that it probably requires type inference, or at least more advanced analysis than what Ruff does today...
> Can we use `ty` in ruff to implement this? Not today, no. Using ty in ruff requires fundamental changes to how ruff works internally. But it's on our long-term...
No, Ruff isn't yet using ty's analysis engine
I might be wrong on this (not a typing expert) but I think this might be due to ty's lack of support for generic protocols (`Iterable` is a generic protocol)....
@MeGaGiGaGon thank you this is very useful. I pointed Claude at it and it was able to minimize the problem further: ```py """Minimal reproduction for ty cycle crash (20 lines)....
Hmm, yeah, this is a bit tricky. We support checking files without extension if you pass them directly to the CLI. But we currently don't support including files without a...
I think we could append the `*.{py,pyi,ipynb}` filter if we see that the glob has no filename part (other than `*`).
Can you hover over `self.zoho_books_client` and share what type ty reveals for it? I wonder if it's a union with `Unknown` (or some other type that isn't guaranteed to have...