Results 1961 comments of MichaIng

I'd probably put the additional output behind a debug flag (for testing it is nice) and assure that the Etag is really set (not empty) before storing it. Others a...

Hmm, works well here: ```sh agent="Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.102 Safari/537.36" curl -s -L --header "If-None-Match: \"cdff4f7d3043f4789209a953ba4c0f7a\"" -w "%{http_code}" -A "${agent}" -I https://s3.amazonaws.com/lists.disconnect.me/simple_ad.txt -o...

Btw, see `heisenbergCompensator`: At least if the `Last-Modified` response header is set, the download will be skipped already. True for e.g. `https://urlhaus.abuse.ch/downloads/text`, but not for `https://gitlab.com/nobodysu/spyware-hosts/raw/master/lists/unity-all.txt`.

> `https://www.googlETAGmanager.com` matches `etag` i guess `sed -n 's/^etag: //Ip'` should rule that out, as HEAD lines always begin with the header names like that. `curl` should assure line breaks...

``` mv pihole-setupVars.conf.example setupVars.conf nano setupVars.conf ./basic-install.sh --unattended ``` ☕ ... ``` systemctl status pihole-FTL ``` 👍 ________ Probably the `pihole-` prefix should be removed from the filename?

> Now, skip step 2, which most of our users will do. This is why the validation function has been implemented. All invalid values need to be re-entered manually then....

> `setupVars.conf` was initially designed to be just a setup file for overriding defaults. That has not changed, as far as I understood the PR? The aim is to make...

> My point is if you want a system that does what you are requesting then fix the system to do that. Patching this current system isn't the proper fix....

@PromoFaux > In an ideal world the install script would just be a simple bootstrapper to download the correct version of FTL, which then goes on to either generate a...

> Bash just isn't meant for what is being done with it. It doesn't matter what whoever meant it for, as long as it works. But probably with C it...