Mo

Results 11 comments of Mo

> > > @Metropass This issue is currently lacking a lot of context, but the gist is: > We currently pass around a lot of our failure status messages as...

I see. I also noticed that on line 554, you pickle the error tuple itself. Would it be a good approach to pass the tuple into the object's constructor, then...

Cool, I'll have some code done by today. I would assume we would make a `status_object.py` to hold the definition of the object, since we're using it in multiple files?

@vringar I got the definition of the object, I added, `tb,error,error_class` from your example, and I also added `logger_info` and `error_text` just so you can store it in the Object...

> > > Thank you for following up so quickly on this. > Two questions on `__del__` and on `clean` because I'm currently don't understand why we need them: >...

@vringar I changed the object to only have `setName` for the Status (case; "OK"), and the attributes that we need. I'll take a look at TaskManager and see how we...

@vringar So, I'm almost finished with this issue, however I'm kind of confused with Line 131 in `BrowserManager.py` https://github.com/mozilla/OpenWPM/blob/c2a700448f31882bf75530eca98f536321b622e8/automation/BrowserManager.py#L129-L131 From what I've understood, the tuple's we worked with in `TaskManager.py`...

> > > Hey, > I'm sorry to say this but I completely underestimated the complexity in this change and don't the approach I originally suggested can work. > I...

@vringar Apologies for the wait, I've been ill the past week, I should have my code done by Sunday, and I just wanted to let you know :)

I might just make a module in Satellite that will add headers onto the passed Response object, I'll add in a test specifically for `Cache-Control`