Ronnie Dutta
Ronnie Dutta
@adiroiban I had a quick go at this, turned out to be pretty easy. Let me know what you think: #622
I think this is https://github.com/cylc/cylc-flow/issues/6429
We are getting close on the sibling PRs, no reason not to merge this as it is backwards compatible
No longer applicable after change of tack
Actually this change still makes sense irrespective of https://github.com/cylc/cylc-uiserver/pull/607
Try ```py if mode == 'list-dir': sys.exit('foo bar baz') ```
Ah sorry, this only applies to network/graphql errors. E.g. try removing the `cat_log_files` function in `cylc/uiserver/resolvers.py`: https://github.com/cylc/cylc-uiserver/blob/dfb1ab41c1284444e37170dd50abd76849469459/cylc/uiserver/resolvers.py#L433
At the moment this PR guards prevents any bug in the UIS code being silent. We agreed it doesn't make sense to show an error snackbar for non-zero ret code...
It's been a while but I think this only applies to errors in graphql execution, not errors in the cat-log command. That comes back to my question > We agreed...
Here's an example ```diff diff --git a/cylc/uiserver/resolvers.py b/cylc/uiserver/resolvers.py @classmethod - async def cat_log_files(cls, id_: Tokens, log: 'Logger') -> List[str]: + async def cat_log_files(cls, log: 'Logger') -> List[str]: """Calls cat log...