cylc-ui icon indicating copy to clipboard operation
cylc-ui copied to clipboard
verified publisher icon cylc

backend graphql-core v3 adjustments

Open dwsutherland opened this issue 9 months ago • 2 comments

partially addresses https://github.com/cylc/cylc-uiserver/issues/333

Sibling to: https://github.com/cylc/cylc-flow/pull/6478 https://github.com/cylc/cylc-uiserver/pull/672

Can be merged at any point.

This is a small/minor change to handle the JSON parsing of proper enums introduced with graphql-core v3.

Check List

  • [x] I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • [x] Contains logically grouped changes (else tidy your branch by rebase).
  • [x] Does not contain off-topic changes (use other PRs for other changes).
  • [ ] Tests are included (or explain why tests are not needed).
  • [x] Changelog entry not needed
  • [x] Docs not needed

dwsutherland avatar Mar 10 '25 04:03 dwsutherland

It doesn't quite make sense to me, but it does appear to work.

Suggest keeping this PR open until the upstream PRs have been merged so it can adapt if necessary.

oliver-sanders avatar Mar 11 '25 17:03 oliver-sanders

It doesn't quite make sense to me, but it does appear to work.

Suggest keeping this PR open until the upstream PRs have been merged so it can adapt if necessary.

I think it's something like parsing "Live" in contrast to passing "\"Live\"" as JSON? As the enum argument value isn't quoted it's just mode: Live not mode: "Live" .. not entirely sure But the new form of enums definitely tripped it up..

dwsutherland avatar Mar 13 '25 22:03 dwsutherland

We are getting close on the sibling PRs, no reason not to merge this as it is backwards compatible

MetRonnie avatar Jun 17 '25 16:06 MetRonnie