Tanguy

Results 88 comments of Tanguy

Just a note, we can also detect IP changes with the libp2p identify protocol (which is used everytime we dial someone/someone dials us) Currently it's not hooked up, need to...

I think the current auto update comes from the DHT, but don't quote me on that

I've been running this for a while, and it seem to give reasonable scores. Only weird thing I saw, we often give invalid message penalties to peer on `beacon_aggregate_and_proof`, which...

Ok, we can avoid storing rejected messages, but not sure how we can prevent double compression in libp2p? We need to compute the message id to dedup before validation, unless...

Ok, so msgIdProvider could fail (we can use an exception, or a ValidationResult), and in that case we skip immediately And if the regular validation failed, we also don't store...

Invalid message are now rejected early, https://github.com/status-im/nimbus-eth2/pull/3438

Oh ok, didn't understand that you also wanted to avoid that. So libp2p should allow you to return custom data from the messageId provider, and forward it back to the...

> "future has failed" Most probably coming from https://github.com/status-im/nimbus-eth2/blob/5b13b7cc9bd52617f81c2b0ce5eae06827741404/beacon_chain/networking/eth2_network.nim#L1257 libp2p expects that conn event handlers don't fail, but errors are not handled properly in this conn handler Shouldn't cause anything...

Linked https://github.com/nim-lang/Nim/issues/19766

What's the status on this PR :) ? Looking forward for questionable to work again on devel