Menci comments

Results 168 comments of


                                            Menci

The plugin don't parse a file that only contains ´ExportNamedDeclaration´ with source

It makes sense! I didn't find any real world Vite output example of `export {} from "...";` statements so I didn't implement that. I had many assumptions of Vite's output...

import.meta -> import_meta

你原本项目的 Vite target 是什么？我的原理是首先以 esnext 编译然后转译，很可能是做了一些 transpile 变成这样的。这里 import_meta 看起来像是上面有一个 const import_meta = import_meta_available ? import.meta : some_polyfill 之类的东西？

import.meta -> import_meta

能提供一个复现吗

fix: parse ExportNamedDeclaration with source

I added tests and fixed the transform logic. The `export ... from` statement should NOT be transformed to `import { id } from` and `export { id }`. We shouldn't...

fix: parse ExportNamedDeclaration with source

Merging since no response.

vite-plugin-top-level-await breaks source map generation in Vite

Yes. I'm sorry it's broken. I didn't handle source-map.

vite-plugin-top-level-await breaks source map generation in Vite

But I have no idea of how to implement this...

vite-plugin-top-level-await breaks chunk's hash generation in Vite

Do you have any idea on fixing it?

Generate sourceMappingURL into javascript file

This PR is enabling source map for this plugin's building, not for Vite building with this plugin running. So, it has nothing to do with that issue. @muhammadhafizmm I don't...

Legacy octal escape sequences cannot be used in an ECMAScript module

Could you please provide a reproduction?