MenD32
MenD32
@towca, could you please take a look at this PR when you get a chance?
Just finished addressing the review comments, so this PR is ready for review again, @jackfrancis @towca
/remove-lifecycle-stale
I wasn't aware of `ptr.Deref`, this is so useful! especially when working with complex Kubernetes structs
> /hold > > /lgtm /approve > > @towca might have some more thoughts on this @towca did you get a change to look at this PR?
I have also experienced this issue, a quick fix is to define the BackendConfig in the GCP console but it'd be very nice to have it work out-of-the-box in k8s
i opened a PR since this change can be pretty easy to implement
i am not sure why kafka E2E fails, since the code changes shouldn't affect it at all. if someone has a clue of why this would happen, I'm open to...
i added a 3 second sleep in the e2e test, since the test was inconsistent with Kafka, even though the changes are completely irrelevant