feat: Support DRA Admin Access
What type of PR is this?
/kind feature
What this PR does / why we need it:
This is a part of Dynamic Resource Allocation (DRA) support in Cluster Autoscaler. ResourceClaims support the AdminAccess field which is used to allow cluster administrators to access devices already in use. This changes the CA's business logic by introducing the idea that "some resourceclaims don't reserve their allocated devices".
Which issue(s) this PR fixes:
Fixes https://github.com/kubernetes/autoscaler/issues/7685
Special notes for your reviewer:
Does this PR introduce a user-facing change?
ResourceClaims with AdminAccess will now be ignored when calculating node utilization for scaledown
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
- [KEP]: https://github.com/kubernetes/enhancements/blob/a55eefc6051d6684d8cc7521e1f4de6319625e23/keps/sig-auth/5018-dra-adminaccess/README.md
Hi @MenD32. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/ok-to-test
/lgtm
/assign @towca
@towca, could you please take a look at this PR when you get a chance?
Just finished addressing the review comments, so this PR is ready for review again, @jackfrancis @towca
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
/remove-lifecycle-stale
/label tide/merge-method-squash
/remove-lifecycle stale
I wasn't aware of ptr.Deref, this is so useful! especially when working with complex Kubernetes structs
/hold
/lgtm /approve
@towca might have some more thoughts on this
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jackfrancis, MenD32
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~cluster-autoscaler/OWNERS~~ [jackfrancis]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/hold
/lgtm /approve
@towca might have some more thoughts on this
@towca did you get a change to look at this PR?