Melanie Sumner comments

Results 243 comments of


                                            Melanie Sumner

Managing common dependancies between the host app and engines

We are having the same issue, and would benefit from some extra documentation/clarification. (+@dgeb)

[DOC] Correct `RESTAdapter` namespace documentation

@btecu @runspired what needs to happen to move this PR forward? Thank you for your work!

Rule request: Linting for “scope” in table headers

I'd be open to this rule- I'd suggest it as a warning and not an error, since in the config you could define that you wanted it to error for...

require-input-label: "Multiple labels" false positive

Using `aria-label` and `aria-labelledby` on the same `` is valid (one is the label, one is for help text). I think the logic here comes from "if it has an...

[Rule idea] No empty non void elements

`` is pretty common to leave blank for reasons. I'd probably recommend removing that from the disallowed list.

Rename and narrow rule `no-down-event-binding` to `no-pointer-down-event-binding`

So some extra thoughts that I added to the original issue: https://github.com/ember-template-lint/ember-template-lint/issues/2028#issuecomment-1035202616

Rule request: `require-valid-form-groups` (or similar)

@rwjblue yup, updated. 👍

Remove `keydown` linting in rule: no-down-event-binding

@camario25 @jfdnc I'm supportive of having this rule refactored to be more correct 👍

Remove `keydown` linting in rule: no-down-event-binding

Update: an example where you would want to use keyup instead of keydown: On a [tabs](https://www.w3.org/TR/wai-aria-practices-1.2/examples/tabs/tabs-2/tabs.html) component, you would want to configure the arrow keys that cycle between the tabs...

Universal test helpers for WAI aria widgets

This is really great! I would love to see this added to Ember Component Patterns - how to test could be its own sub-section per component. Let's also get the...