GitHubSdk icon indicating copy to clipboard operation
GitHubSdk copied to clipboard

Published 20 hours ago • verified publisher icon Meisolsson

Update GitHubEventType

Open Meisolsson opened this issue 6 years ago • 2 comments

I've been doing some checks on what is actually sent to the timeline and we have som extra things which are only sent to Web Hooks. We are also missing some events.

Here are the lists:

No longer in timeline

  • DownloadEvent
  • FollowEvent
  • ForkApplyEvent
  • GistEvent

Never been on timeline

  • DeploymentEvent
  • DeploymentStatusEvent
  • GitHubAppAuthorizationEvent
  • LabelEvent
  • MembershipEvent
  • MilestoneEvent
  • OrganizationEvent
  • OrgBlockEvent
  • PageBuildEvent
  • RepositoryEvent
  • StatusEvent
  • TeamEvent
  • TeamAddEvent

Only for GitHub apps

  • ContentReferenceEvent

Currenly missing in library

  • InstallationEvent
  • InstallationRepositoriesEvent
  • MarketplacePurchaseEvent
  • ProjectCardEvent
  • ProjectColumnEvent
  • ProjectEvent
  • PullRequestEvent
  • RepositoryImportEvent
  • RepositoryVulnerabilityAlertEvent
  • SecurityAdvisoryEvent

Not sure

  • CheckRunEvent
  • CheckSuiteEvent

@maniac103 I'd like some input on this and I know you guys use the library. Anything here that you can see is wrong?

Meisolsson avatar Feb 23 '19 14:02 Meisolsson

@Meisolsson List looks good with the exception of PullRequestEvent: this most definitely is present in the library, as we're currently using it already: this is the list of events we're using.

maniac103 avatar Feb 25 '19 13:02 maniac103

Alright, I think that one slipped when I was comparing everything. I'll get to doing this soon.

Meisolsson avatar Feb 25 '19 19:02 Meisolsson