Meir Blachman

Results 154 comments of Meir Blachman

@premun I think the issue here is only for the parameter-typed templates due to us having the implicit convertion operator to `Template`. in order to ensure the typed-paramteres template is...

@premun for example - https://github.com/dotnet/arcade/blob/992d2e5d76cccb72ad611ba2141e25db86cd59bd/azure-pipelines.yml#L38C1-L52C19 ```yml extends: template: v1/1ES.Official.PipelineTemplate.yml@1ESPipelineTemplates parameters: pool: name: $(DncEngInternalBuildPool) image: windows.vs2019.amd64 os: windows sdl: policheck: enabled: true tsa: enabled: true stages: - stage: build ``` Any...

getting the error `The 'buildType' parameter value '$(buildType)' is not a valid value.` which means the variable was not found.

@premun it's not going through the `TaskInputs` type, it's the `TemplateParameters` type I'm not sure about this but maybe this would work? ```csharp public class TemplateParameters : ConditionedDictionary { public...

> I see.. Maybe we want the `TaskInput` to turn those into the right references and force the `${{ }}` form I'm not sure I follow this suggestion

would we want special handling for the predefined variables which (I think) could always be referenced using `$()` syntax?

I think that when passing a variable reference as a parameter, when the variable is a custom one (not one of the built-in ones) we would need to pass as...

current status: annotated class: ```csharp [SharplinerTemplateParameters] public partial class CorePostBuild : StageTemplateDefinition { } public class CorePostBuildParameters : CorePostBuildParametersBase { } public abstract class CorePostBuildParametersBase : TemplateParametersProviderBase where TSelf :...

new generated code: ```csharp using System; namespace Sharpliner.Tests.AzureDevOps; partial class CorePostBuild { protected static new readonly CorePostBuildParametersReference parameters = new(); protected class CorePostBuildParametersReference : Sharpliner.AzureDevOps.TemplateDefinition.TemplateParameterReference { /// /// A parameter...

Looks like I missed the docker files, I'll see what's missing here