Meir Blachman

Results 154 comments of Meir Blachman

Oh, my bad. The idea would be to mock the virtual method instead. Making the method virtual allows mocking it **modified the code sample to highlight the new approach

https://github.com/dotnet/aspire/blob/c029d9caa81ca6bbae49f47925c12a5a04d78ebf/.github/copilot-instructions.md?plain=1#L31 @RussKie why not use Moq?

I think that to achieve this we could aggregate all of the variable definitions (through `strategy.matrix` and `variables`), have a metadata object with variable name, type & context. then, convert...

Chrome shipped this in 125 - https://chromestatus.com/feature/5848709993857024

I think this is partially addressed by #340 in addition we could add another validation that the condition using some parameter will have to match the parameter type so: ```csharp...

maybe we could introduce something like this - ```csharp public abstract class TemplateDefinition : TemplateDefinition, ISharplinerDefinition { ... protected new TemplateParameterReferenceWithValidation parameters => new(); protected class TemplateParameterReferenceWithValidation() : TemplateParameterReference {...

I wonder if a better solution here would be to support something like ```csharp StageTemplate("the-stage", new() { ["myParam"] = parameters[myParam], // new(parameter.Name); } } ```

So let's split this into two parts, the first with the indexers which is pretty clear #380, the `ConditionedDictionary` will have a larger impact and would probably take longer to...

https://github.com/dotnet/test-templates/pull/325 introduced the templates `nunit-playwright` and `mstest-playwright`

Are there tests for the source-generator? do the orleans integration tests cover this as it's required for orleans to work?