McCode

McCode copied to clipboard

TOFRes_sample issue in McStas 3.4: Missing modifications long the lines of Res_sample

2

TOFRes_sample should use component-injected `USERVARS` as in `Res_sample`, see e.g. https://github.com/McStasMcXtrace/McCode/commit/0561e40d3cde6098cb32f659d990d8a713860582 Issue reported by Ryoichi Kajimoto via `mcstas-users` (https://mailman2.mcstas.org/pipermail/mcstas-users/2023q4/001508.html) and quoted below. Also, a test/unit-test instrument should be defined for...

willend

McStas mcdisplay-mantid / Monitor_nD use of scientific notation in idstart= fields causes IDF files not to load

2

Example: ``` ... cut ... ``` [PG3_polarised.instr.xml.txt](https://github.com/McStasMcXtrace/McCode/files/12868860/PG3_polarised.instr.xml.txt)

willend

MCPL_ouput and MCPL_input are inconsistent with file extension handling

3

## Background ### `MCPL_output` By default the `MCPL_output` component uses its own component name as its output file name. https://github.com/McStasMcXtrace/McCode/blob/e56b1e3557d5ca3b3eded624a49e1ef9a22ebfff/mcstas-comps/misc/MCPL_output.comp#L93-L97 Which seems reasonable. It then specifies (in single processor mode)...

g5t

cmake_minimum_required 2.x is too old

2

https://github.com/McStasMcXtrace/McCode/blob/2f807a909b79f3105a770c986cf1a622b9afc212/mcstas/CMakeLists.txt#L1C1-L2C1 Causes warnings in conda builds (where CMake is brand new) like: ``` CMake Deprecation Warning at mcstas/CMakeLists.txt:1 (cmake_minimum_required): Compatibility with CMake < 3.5 will be removed from a future...

tkittel

DEPENDENCY should only add to CFLAGS if the given flags are not already present

2

Plus check if the string buffer limit is near.... https://new-nightly.mcxtrace.org/2023-09-26/McXtrace_CPU_MPICC_KISS_5e7/Test_SAXS/compile_stdout.txt

willend

Due to a new application of "particle identification" in Union, @mads-bertelsen needs unique particle identification, also across MPI nodes. For this purpose and still having access to a "simple particle...

willend

It seems the McStas .desktop shortcut is not included with installation of 3.4 on e.g. Ubuntu. As a workaround, please run the command ```mcgui``` from within a terminal.

willend

Fractal SasView models (and potentially further ones) need -DUSE_CUDA in case of OPENACC

2

It works to add a small patch at the top of `sas_kernel_header.c` like this and attached: ``` #ifdef OPENACC # define USE_CUDA #endif ``` [sas_kernel_header.c.txt](https://github.com/McStasMcXtrace/McCode/files/12697960/sas_kernel_header.c.txt) But perhaps we should do...

willend

Uses Conics_EH_fixed and Conics_PH_fixed-> should be Conics_EH, Conics_PH. Fixed on main in 1f1ab6dc0, download corrected instr here: https://github.com/McStasMcXtrace/McCode/blob/main/mcstas-comps/examples/WOFSANS.instr

willend

Fedora mcstas-suite-python-ng refers to mcstas-mcpl package

1

Needs updated "metapackage" that refers to generic-name mcpl / ncrystal pkgs

willend