Mayank Sharma
Mayank Sharma
Also I'd like to hear your thoughts on this feature as well
Hey @M4dhav, the PRs for those issues are already open, even if some changes are suggested those can be done simultaneously as those PRs are not very big. I feel...
I meant i appreciate your inputs but i can manage it on my own
Hey @M4dhav, if you are unable to review the prs currently, as I have already made requested changes 3 days ago, please assign me this issue to me and I'll...
i would like to work on this
I'm working on this, will be done by next week
Hey @4555jan I've already completed this, waiting for him to review my existing pr, then I'll open pr for this
At work currently
Hey @M4dhav, As i mentioned in #556 adding unit tests to upcoming_room_controller is not possible currently without extensive refactoring due to it being too tightly coupled with room_controller. I'd like...
I had to refactor the upcoming_room controller, it was untestable as there were many hard coded intialized controllers(direct Get.find()) that were making it untestable. I refactored the UpcomingRoomController to remove...