No Option to Delete Created Rooms

[Sharma-Ji-21]

🚀 The feature

Description:

Currently, after creating a room, there is no option to delete it from the UI. Users should have the ability to remove rooms they no longer need.

Expected Behavior: • A delete button should be added to each room card, allowing users to remove unwanted rooms. • The app should ask for confirmation before deleting a room to prevent accidental deletions. • Once deleted, the room should disappear from the list immediately.

Steps to Reproduce: 1. Create a new room. 2. Go back to the homepage. 3. Notice that there is no option to delete the room.

Motivation, pitch

Motivation: The ability to delete rooms is essential for maintaining a clean and manageable user experience. Without a delete option, users are forced to keep unwanted rooms, leading to clutter and potential frustration. This issue becomes even more significant as more rooms are created, making it harder to navigate and organize active discussions.

Pitch: Implementing a delete button will enhance user control over their created rooms, allowing them to remove unnecessary or outdated rooms. This feature will improve the app’s usability, making it more intuitive and efficient. Adding a confirmation prompt before deletion ensures that rooms are not removed accidentally, balancing functionality with user safety.

[Sharma-Ji-21]

@Aarush-Acharya @chandansgowda please assign this to me

[sandy4242]

Hi! 👋 I'd love to work on this issue. I have worked with a similar issue of deleting a Proposed Fix: Add a delete icon (e.g., trash bin) next to rooms the current user has created (in the room list or room details). It can also be modified that the user / room creator gets a list of rooms that he wants to delete

the image below is form my project i have worked in...

On tap, the user with a confirmation dialog (e.g., “Are you sure you want to delete this room?”).

If confirmed: Remove the room entry from the database, refresh the room list to reflect the deletion. Ensure only the room creator (or users with appropriate permissions) sees the delete option.

If this approach sounds good, I'd be happy to go ahead and open a PR!

[M4dhav]

Hey @sandy4242 , as @Sharma-Ji-21 requested to work on the issue first, will assign to him. Thank you for your interest!

@Sharma-Ji-21 you can start working on this

[sandy4242]

@M4dhav hey how I get inti contributing here, most of issues are given by the contributors themselves...so no scope for new comers to contribute here!!

[M4dhav]

Hey @sandy4242 , you can take a look at #497 and #498 or you can run the app locally and think about some feature you would like to add which would be valuable to the community, or fix any bugs that you end up finding.

[M4dhav]

@sandy4242 as there has been no activity on this issue for a month, you can take this up if you want, please confirm and I will reassign the issue

[Mayank4352]

i would like to work on this

[M4dhav]

Assigning to you @Mayank4352

[sandy4242]

umm was i late to take up this issue @M4dhav?

[M4dhav]

Hey @sandy4242 , since there was no response from your side I did not assign it to you, I am sorry about that.

[sandy4242]

not an issue @M4dhav, well if again faced with same issue of inactivity, do assign it to me, happy to help.

[sandy4242]

or any open issues that you would recommend me to work / look into? @M4dhav

[M4dhav]

@sandy4242 there are a couple of issues you can take a look at, #465 #460 #442 #415 #519

[M4dhav]

Hey @Mayank4352 , any updates on this?

[Mayank4352]

I'm working on this, will be done by next week

[4555jan]

will u please assign this issue to me @M4dhav i will get done with it easily

The room disappears immediately after deletion.

A SnackBar or toast confirms successful removal.

Errors gracefully notify the user.

[Mayank4352]

Hey @4555jan I've already completed this, waiting for him to review my existing pr, then I'll open pr for this

[4555jan]

@Mayank4352 you already opned the pull request ? can we please talk on discord ? i have a doubt regrading something

[Mayank4352]

At work currently

[M4dhav]

Closing as fixed by #557 and #590

[github-actions[bot]]

🔒 Issue Closed - Thank You, @M4dhav!
This issue has been resolved or is no longer relevant.

• If you have further questions, feel free to open a new issue. 💡

Thanks for helping improve the project! 🚀

[M4dhav]

Hey @Mayank4352 sorry, I forgot to ask you to add tests within the PR, could you please add tests for this functionality

[Mayank4352]

Hey @M4dhav, As i mentioned in #556 adding unit tests to upcoming_room_controller is not possible currently without extensive refactoring due to it being too tightly coupled with room_controller. I'd like to hear your thoughts regarding the same

[M4dhav]

Then leave the tests for the coupled functions but write the tests for the functions you implemented. If even they are coupled, then decouple them and write tests for them

[Mayank4352]

I had to refactor the upcoming_room controller, it was untestable as there were many hard coded intialized controllers(direct Get.find()) that were making it untestable. I refactored the UpcomingRoomController to remove the direct Get.find() calls from field initializers, which made the controller untestable since those initializers run before the constructor. The controller now uses constructor-based dependency injection, following the same testable pattern used in ChangeEmailController and EditProfileController. This makes the logic easier to mock and ensures the controller is testable

[M4dhav]

Closing as tests are added in #595

[github-actions[bot]]

🔒 Issue Closed - Thank You, @M4dhav!
This issue has been resolved or is no longer relevant.

• If you have further questions, feel free to open a new issue. 💡

Thanks for helping improve the project! 🚀