Max Kellermann

I don't think we should change XCSoar's definition of overload factor. I rather think we should remove XCSoar's definition completely, because it's a useless metric. See https://github.com/XCSoar/XCSoar/issues/1319#issuecomment-1878567839

You requested a review, but your code was already reviewed in https://github.com/XCSoar/XCSoar/pull/1261 and apparently you didn't obey the review. I wish you hadn't closed https://github.com/XCSoar/XCSoar/pull/1261 because now we're wasting time...

> i did spend quite some time complying to what lordfolken advised. Just look at the **very first** review comment: https://github.com/XCSoar/XCSoar/pull/1261#discussion_r1253499298 Then look at this piece in this PR you...

Oh no, now you suggest merging a merge commit. Everything is wrong with this PR. I suggest you should continue working on https://github.com/XCSoar/XCSoar/pull/1261 and not this one, because over there,...

> Max isn't very tolerant of when things aren't done in the way he expects. First of all, I expect people to handle the existing reviews before asking for another...

@qubolino you're trying to reframe your failure to read review comments carefully, making it sound like it's about me. Please don't make this personal. This doesn't help, you're only wasting...

> However the [LX Manual](https://gliding.lxnav.com/wp-content/uploads/manuals/S8x-S10xManualEnglishVer908rev62.pdf) p.84 gives a different formula: How is this formula different, and is this difference relevant for this bug? (Please do not use the term "weight"...

@kobedegeest, so that's a "yes"? > XCSoar divides by dry mass which makes no sense It makes no sense only with your personal definition of "scaling factor", but it does...

> The overload factor is defined as the current total mass (crew + empty plane + water ballast) / (the polar reference mass) Who exactly defines it that way, and...

The LXNAV LX9000 manual also uses "minimum glider weight", not "reference mass".