Max Kellermann
Max Kellermann
So I figure this problem has nothing to do with XCSoar, but is just "shit in shit out"?
Apparently, this has never been observed again.
I tried to reproduce your problem. 1.+2. I saw no "toggling", I always saw the correct distance to the cylinder boundary 3.+4. Start is not scored when exiting the start...
> LoadTerrain runs asynchronously. Right? How can Startup know it's done? `AsyncTerrainOverviewLoader` signals a `UI::Notify` when it's done, and that's `MainWindow::terrain_loader_notify`, and its callback function is `MainWindow::OnTerrainLoaded()`.
I do think each waypoint should be able remember how the elevation was determined, and every time new terrain gets loaded, all waypoints which have terrain elevation (or no elevation)...
There's ``` bool has_elevation = false; ``` Replace it with: ``` enum class ElevationSource : uint_least8_t { NONE, FILE, TERRAIN, } elevation_source = ElevationSource::NONE; ``` This way, we don't even...
Too fragile - what if somebody adds a new enum choice eventually? Then the value will get overwritten, without a compiler warning.
Everything else, including future enum choices that you cannot imagine yet? I can imagine one: USER for values entered by the user. Do you want to discard and override those?...
Rebased & fixed `CHANGES.md` conflict.
> The CHANGES.md entry needs to be moved to the changes between ~3.3 and 3.2~ 3.1.4 and 3.1.5 section. As this is a bug fix that is going to be...