Max Kellermann

Results 514 comments of Max Kellermann

Is there really no way to do that natively with Meson, without resorting to a shell script? (And btw your shell script is unsafe .... it's the kind of awful...

Maybe *moving* the file wasn't a good idea anyway, because moving an output file will cause it to be rebuilt; and copying files is something Meson can do: https://mesonbuild.com/Fs-module.html#copyfile

> when it would be easier and safer for users to use an existing reverse-proxy server The whole idea of the `httpd` output plugin is that MPD gives you something...

> Maybe a note in the appropriate documentation would help. Agree. The presence of this feature should not pretend it's truly secure, when it cannot possibly be (because the transport...

Looks like @Mrkvak is not interested in fixing the issues, and I only wasted my time with the code review.

Ouch, the PR branch now contains merge commits. This is a big mess that cannot be reviewed. Please fix this.

There are now commits which obviously fix mistakes in earlier commits of this PR, e.g. "working version". I don't want to read known-bad commits and find all those mistakes again,...

"If you find a mistake in a commit that is not yet merged, please amend the commit instead of adding a fixup commit."