MaxBreida comments

Results 4 comments of


                                            MaxBreida

GoCloak is not an interface like documentation describe it

The change has been done to adhere to the `accept interfaces, return structs` principle. https://github.com/golang/go/wiki/CodeReviewComments#interfaces https://dave.cheney.net/2016/08/20/solid-go-design https://mycodesmells.com/post/accept-interfaces-return-struct-in-go Although yes, maybe the readme should be updated to not get people confused...

Sort events before applying them to aggregate

Hey, why the decision to do this manual kind of sorting instead of using the sort package?

Sort events before applying them to aggregate

> @MaxBreida > > Today we suffer in tests from this bug, so I take a new look into it. > > I reverted original solution and I provided now...

Fix possible race condition on request ctx done

Hey, we also receive sometimes a panic in our services with the following stacktrace, could this be related to this issue? ``` panic: runtime error: invalid memory address or nil...