Matthew Tighe
Matthew Tighe
@delia-pop Is the snackbar only displayed one time, and only for users upgrading with those 3 wallpapers? Or is it displayed every time the app is launched? If the first...
> It makes sense for the snackbar to be displayed only for Cerulean, Amethyst and Sunrise wallpapers, as they are the only ones which are [downloaded and not migrated](https://github.com/mozilla-mobile/fenix/blob/f8682dab94e7fb2f611e1541b3735a7f1d026f02/app/src/main/java/org/mozilla/fenix/wallpapers/LegacyWallpaperMigration.kt#L42) (because...
Since this bug will only be hit once for upgrading users and we weren't able to address it in time for 106, I think we are safe to close this...
@gabrielluong I discovered that we look to be caching whether a user has signed in [in this observer](https://searchfox.org/mozilla-mobile/rev/89f662c413b63fa69c4660bc1a09b2614cb73bcc/fenix/app/src/main/java/org/mozilla/fenix/components/BackgroundServices.kt#224) so we could potentially reuse that to fix this bug.
> Is this something we still want to move forward? I feel that we should at least first prevent close together syncs before we design/add support for caller to specify...
I think we should add the following to handle these special cases. Since this won't be long-lived code, I would prefer to handle every edge case explicitly even if the...
@sunilk9211 Sure, this seems like a good issue for a community contributor to pick up! I added some more explicit acceptance criteria to the OP to try and help guide...
For the purposes of this issue we want to remove only the following: 1. the ability to click the logo to change the wallpaper 2. checks around whether the logo...
@MasterInQuestion It is optional, but the decision has still been made to remove it based on the reasons quoted in the original issue, in addition to the fact that it...
@MasterInQuestion We aren't really interested in continuing to maintain the feature, and its existence is having an impact on our ability to plan improvements and additions to the wallpaper feature...