Close #12645: Add sync engine aware debouncing
Pull Request checklist
- [x] Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [x] Tests: This PR includes thorough tests or an explanation of why it does not
- [ ] Changelog: This PR includes a changelog entry or does not need one
- [ ] Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features
After merge
- Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
- Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.
GitHub Automation
Fixes #12645
For a cleaner review, I didn't fix the trailing comma issue for ktlint. I will fix ktlint in a separate PR once this is approved.
@MatthewTighe, @jonalmeida Is this something we still want to move forward? I feel that we should at least first prevent close together syncs before we design/add support for caller to specify custom debounce time.
Is this something we still want to move forward? I feel that we should at least first prevent close together syncs before we design/add support for caller to specify custom debounce time.
Thanks for the reminder about this! I think we should, and I'll plan to give this a thorough review either later today or tomorrow. Been trying to wrap up the thing I'm on before context-switching fully in to Sync again, as I'd like to make some plans for task continuity improvements for Q4/Q1.
I've removed the ktlint fixes with the assumption that this change will wait for the project wide ktlint fixes to land first.
I do think we should prioritize configurable debounce times at the call-site, so that we can re-increase the default. I'm a little concerned the current value could generate an unexpected amount of traffic somehow. I would be happy to work on that if you're otherwise busy, just LMK
Sure, please let me know when you want to start looking into it and maybe we can look at the design together. Thanks
This pull request has conflicts when rebasing. Could you fix it @rocketsroger? 🙏