Matt Steen
Matt Steen
I'm going to add the CHW (4.10) and HW (4.11) Plants on a separate branch and open a pull request to merge into this one.
I'm going to go through the existing air-side shapes and templates to clean them up on a separate branch and open a pull request to merge into this one.
> There's one change I had to make in the `5.16.14` file on `fc-6`: https://github.com/NREL/BuildingMOTIF/pull/348/files#diff-031b58b351782baacd1cd272ac8e5b45aa72d7e18c141b1c71147009dfc45fea to get tests to pass. Hopefully #348 passes soon so we can fix the build...
@gtfierro this is almost ready but I think it needs #346 for the checks to pass.
@gtfierro not at all. I noticed the `buildingmotif/libraries/brick/Brick.ttl` file is wrong here (missing `rec` prefix). Probably happened in one of my attempts to resolve merge conflicts.
@gtfierro I think my commit https://github.com/NREL/BuildingMOTIF/pull/263/commits/1a42b32781e2eeaea375355f251e4fefc59b5162 has some unintended file deletions, which I'm working on.
The integration tests take >3h so I think we should refactor our CI/CD after the release for quick feedback (e.g. only testing with Python 3.11).
The docs build from this branch have some issues so I'm going to evaluate the develop docs to determine if it'd be less work to get those working for the...
I think we talked about whether we want to include _all_ implementations, or just `conjuncts/protos` as the _only_ way to implement Haystack, which is my preference to align it with...
Gabe's work on this. https://github.com/gtfierro/Brick-Haystack-harmonization