Matthew Heath
Matthew Heath
@lukewilliamboswell yes,. I don't think I have permissions for making a pull request to the real repo, but I'll try to the changes on a branch of my forked version...
Oh... this does not work quite how I thought it did though. It will take longer
Oh it actually is pretty simple, the pointer just needed to be passed to the dealloc as a type with the same alignment : Here is the branch https://github.com/MatthewJohnHeath/rocSHA/tree/7287-Make-testing_roc_alloc-align-the-allocation
Technically it is aligning as whatever @ alignOf(usize) is. Making it 8 on arbitrary hardware is probably possible, but it's trickier and there isn't an obvious benefit. EDIT; `@ alignOf`without...
OH wait again! It was meant to be to 16!
OK this is[ the PR](https://github.com/roc-lang/roc/issues/7287) (The git hub instructions to link the issue and the PR are not working for me)
It should be, but I think I stopped a mistake in my code that was merged there....
Hi Luke, Sorry I'm slow to respond. I've been travelling. There are definitely some problems on the branch; it builds but then in the REPL the functions seem to be...
> Also, there's no code currently to extract state from the new `Digest256` opaque type. Could you add a function or something to do that? Maybe `Crypt.digest256ToBytes : Digest256 ->...
> Tests are currently failing. @MatthewJohnHeath do you have time to implement the above fixes any time soon? If not, I can help, but it's your PR, so I'll defer...