Matthew Hambley
Matthew Hambley
This change is being made piecemeal as other changes are made.
Best to keep vector graphics as vector graphics. If LaTeX extension can't be found to handle SVG then convert it to EPS.
If separate categories are overkill for none compiler tools the next obvious question is "Why have them for tools?" Is everything "misc"?
I was imagining the decorator pattern. (not to be confused with Python decorators which are a bit different) In this approach the MPI class would accept a compiler to its...
I have discovered a case of an alternative workaround whereby global scope module variables are being used to pass arrays "around the side" of the argument list. Clearly this is...
> Can you put a comment next to this usage with the PR reference number please @MatthewHambley, just to make it easy to search for places it needs changing when...
This issue no longer seems relevant. `SourceTree.get_tree` is unhinted but is also abstract. `FortranSource.get_tree` is hinted to return an `fparser.Program` and `PlainText.get_tree` returns a `Generator`.
I'm about to start a review but I'll leave this comment here for immediate consideration. Are you aware of `FabException` in https://github.com/MetOffice/fab/blob/main/source/fab/__init__.py? Have you considered how this interacts with your...
> I know that you consider disabling warnings bad. My suggestion would be to just use `api.py` in this PR, and you can introduce the API versioning as a separate...
This will require a fix to fParser, see /stfc/fparser/issues/390.