fab icon indicating copy to clipboard operation
fab copied to clipboard

Restyle repository to 80 columns.

Open MatthewHambley opened this issue 1 year ago • 3 comments

Simply bumping up the acceptable line width doesn't seem like a good way to tackle the problem of overly nested structures.

This change removes the special settings and restyles everything to 80 columns with exceptions where doing so would tie us in knots.

This change does not attempt to tackle any of the problems such as the powerful odour coming from all the mockery in unit tests.

MatthewHambley avatar Jul 10 '24 07:07 MatthewHambley

While I totally agree with the 80 column column width, can we wait with this? We are at least 4 PRs ahead of trunk (and I have been reformatting things to 80 columns :) ), so please let us check what kind of conflicts this creates for us. I assume this is done with black (or a similar tool??), so we could do this on our end as the PR after if we have too many conflicts?

hiker avatar Jul 10 '24 23:07 hiker

I have no problem with pulling this change if it messes with what you are doing.

MatthewHambley avatar Jul 11 '24 08:07 MatthewHambley

It causes over 20 conflicts for us, not sure how much effort it would be to fix them :( Did you just run black (or any other tool) on the sources? If we can re-run whatever you did, I would prefer that. But if you have done it manually, then we might have to bite the bullet and resolve the conflicts :( FWIW, we are currently trying to change our fork to point back to this repo, atm we are 'disconnected', and can't even easily submit PRs anymore

hiker avatar Jul 12 '24 03:07 hiker

This change is being made piecemeal as other changes are made.

MatthewHambley avatar Nov 19 '24 09:11 MatthewHambley