MatthewFlamm

Results 336 comments of MatthewFlamm

Locally testing #5453 with fixed versions of cmocean and meshio, I don't get any errors in our tests. So, I think we can merge #5453 and then wait for cmocean...

#5460 shows that downstream packages also need us to fix this. So, it might be good to prune the numpy 2.0 tests to something reasonable and merge to main. We...

I added in installing `cmocean` and `meshio` from PR branches in the CI that fix those packages. We are now having more errors. ~I must have messed up the install...

We are now getting errors that seem to be related to https://github.com/numpy/numpy/pull/25553

#5493 and #5496 should fix all errors except one in our tests. An example error message below: ```txt def to_opacity_tf(self): """Return the opacity transfer function of this table. Returns -------...

We should first investigate whether this is the intended behavior in the code. If it is, then we should wait to see if it is a bug/planned-change in numpy or...

From discussion in the numpy issue, it seems likely that this will be a bug that is fixed in numpy (hopefully before the release!). I cannot figure out what the...

@user27182 pinging you so you are aware of the errors in the tests for the validation functionality with numpy 2. The tracebacks are extremely long, but this is an example:...

> Thanks for the heads up. What do you recommend for fixing these? E.g. should I install numpy 2.0 locally with the main pyvista branch, and make a separate PR...

Reworked this PR to simplify things and allow it to be merged to main. However, it is currently using `continue-on-error: true` for numpy 2.0 tests. This will make it show...