Matthew Dorner

@mickmister Think it would work to use a wrapper or decorator around the GitLab client calls? Otherwise, every method that makes GitLab calls must call `checkAndRefreshToken` in its setup stage,...

@mickmister unless you have a strong preference, I think I like locating the GitLab token error handling closer to the GitLab client calls, and to ensure it will be called...

> I'm thinking that sending multiple DMs is an ok outcome, as it's relatively harmless, and any defense around this is going to be complicated and potentially error-prone. @mickmister yes,...

@mickmister Converting to draft because still having issues. The issue is related to the conversation https://github.com/mattermost/mattermost-plugin-gitlab/pull/298#discussion_r886170548 and case where the 4 API requests happen simultaneously, as well as the previous...

The issue is made more difficult by the fact that GitLab's OAuth implementation does not allow a `refresh_token` to be used multiple times. It issues a new one upon each...

@mickmister We are refreshing the token manually. That auto refresh is a separate feature that's discussed in the thread I linked but I don't think it works here since the...

@mickmister @DHaussermann Using `cluster.Mutex` fixed the concurrency issue. As a heads up, I found a lot of instances of other people having this problem with OAuth providers that implement a...

> At the moment, it seems the backend is a bit bloated with the code duplication from the PR. Can we move the code to a middleware function, similar to...

@mickmister - Should we also have the mutex for the `/connected` endpoint? It doesn't use `attachUserContext` which is where I put the mutex code. But, it sometimes calls `GetToDo` which...

Not sure why the CircleCI checks are timing out.