mattermost-plugin-gitlab
mattermost-plugin-gitlab copied to clipboard
mattermost
[GH-262] Merge request approval subscription
Summary
Add DM and Channel notifications for Merge Request approved and unapproved webhook actions.
Ticket Link
Fixes https://github.com/mattermost/mattermost-plugin-gitlab/issues/282
Hello @MatthewDorner,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
Changed the messages, anything else to do?
@MatthewDorner Make sure you either mention someone when asking a question or re-request review from the person if that's the context of the question
Codecov Report
Patch coverage: 100.00% and project coverage change: +0.15 :tada:
Comparison is base (
21beec5) 32.27% compared to head (6bc336c) 32.43%.
Additional details and impacted files
@@ Coverage Diff @@
## master #307 +/- ##
==========================================
+ Coverage 32.27% 32.43% +0.15%
==========================================
Files 21 21
Lines 3433 3441 +8
==========================================
+ Hits 1108 1116 +8
Misses 2215 2215
Partials 110 110
| Impacted Files | Coverage Δ | |
|---|---|---|
| server/subscription/subscription.go | 95.45% <ø> (ø) |
|
| server/webhook/merge_request.go | 87.75% <100.00%> (+1.08%) |
:arrow_up: |
| server/webhook/webhook.go | 53.26% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!