Mathieu Puech

Results 9 comments of Mathieu Puech

This PR is just a proposal, we can use your implementation if you are more advanced in the work. There was some discussion about API here: https://github.com/ing-bank/lion/discussions/903 In this discussion,...

The list of feature seems good to me :) It's a lot of feature, I don't know if we need to add all of theses features from the beginning. And...

@tlouisse Is there anything I can do on the code you've started to do with menus? I suppose this PR could be closed with your code.

> @tlouisse Is there anything I can do on the code you've started to do with menus? > > I suppose this PR could be closed with your code. I...

> Would you still be up to work on this? Yes, I can work on this, let me know when it's rebased and what can I do to help

I'm testing on a windows for the event propagation. On windows, the event is dispatched when you press Enter even if the value changed in the display ![2020-05-13_10-08-17](https://user-images.githubusercontent.com/9367152/81823263-23201600-9502-11ea-99ac-36ba77e0b02b.gif)

there issue is still here, in our subclass, we have added a `change` event that is dispatched only when it should: ```javascript setCheckedIndex(index) { super.setCheckedIndex(index); if (this.formElements[index] && this.__oldIndex !==...

I didn't know there was such verification now (7 days max in future instead of 30 days). We will wait few days as it should be GA soon: https://github.com/Azure/AKS/issues/5328

I’m still waiting for the official date for 1.34 on AKS, it’s still in preview. Check the linked issue in my previous message.