Mathieu Lamiot

Results 242 comments of Mathieu Lamiot

So fast! Awesome :) Adding the "test by devs" label then, if we can rely on E2E

@wordpressfan I see in your latest version that you are using `screen.width` rather than `innerWidth` and pixel ratio. Can you elaborate on why? I am afraid this will cause issues:...

EDIT: very quick test with commit c35559c039626de66f196f799069fc0ded8169f3 seems working. - SaaS visits trigger a row in DB with Mobile & Desktop - Manual visit with a mobile trigger a row...

I think there is a misunderstansing here. innerWidth returns CSS pixels. The devicePixelRatio can be used to go from CSS pixels to Physical pixels. So for Iphone SE, there are...

Here are the details for a Samsung Galaxy s8+ as mentioned by @Mai-Saad The CSS resolution should be OK with our threshold. We should be getting 360 and a bit...

@wordpressfan @Mai-Saad To know exactly what to do, we need to pick a phone model, get its online specs (CSS pixel and screen size) from the website I shared above...

The specification is always the same: for mobile devices, anything bigger than 393x830 must be discarded. It means a Samsung Galaxy s8+ of 360x740 must be accepted. the issue reported...

Ok, I managed to reproduce and this is much more tricky, but does not seem related to the script. Using dev tools to fake a Galaxy S8+, the innerHeight returned...

This seem to happen on our templates. I can't reproduce on my personal website. I am wondering if the template loader plugin could be the cause of this as we...

I think I got it. When loading most WordPress sites, I can see this in the : `` But this is not in the templates we use for e2e website....