Mathew Estafanous
Mathew Estafanous
@kisunji Sorry for the ping, but do you have any ideas as to what might be the cause for the failed integration tests? I don’t really understand how my changes...
Ahh ok, that makes a lot more sense. Thanks! I also just realized that I opened this PR with my dev branch instead of the proper branch `replace-fsm-registry-pattern`. 😅 Is...
yup it should be ready for review!
I've opened a draft PR (https://github.com/testcontainers/testcontainers-go/pull/2035). I'd appreciate any set of eyes on the PR and/or feedback on the implementation.
Thanks for reviewing! I appreciate it. > @ preventing circular dependencies, sounds reasonable but not sure it should be a blocker, can always followup with such in a different PR...
> ....if they're knowledgeable about the semantics required to do so they should be knowledgeable enough to realize it probably wouldn't work as expected. Agreed, it would be quite the...
> Perhaps we can make the type of DependsOn a custom type/interface (pseudo-type union) we could then implement it as-is and extend in the future? Not sure what you mean...
I agree that the implemented solution isn't as easy to use and I think it would be be better to work on a solution similar to your proposed 2nd solution....
Hey @mdelapenya I just want to bump this conversation. Have you had time to review my comments? I understand if this on hold due to scheduling. Thanks!
Hey @pablochacin, thanks for your input! And sorry for not getting back earlier. > What I don't see is how this could work, as we need this address before starting...