Fangrui Song comments

Results 147 comments of


                                            Fangrui Song

ccls should error when the (default) resource directory does not exist

The Clang resource directory is a mix of: * Linux glibc specific auxiliary files like `stdint.h` supposed to be provided by the compiler * headers for x86 intrinsics * `ppc_wrappers`...

Wrong diagnostics on macOS w/ clang10

https://github.com/MaskRay/ccls/wiki/Build#macos this works for me on arm64 macOS. ```sh #!/bin/sh exec /opt/homebrew/bin/ccls --init='{"clang":{"extraArgs":[ "-isystem/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1", "-isystem/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/12.0.5/include", "-isystem/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include", "-isystem/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include", "-isystem/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks" ]}}' "$@" ```

First attempt to include the semantic highlight feature, introduced in specification 3.16.0.

Thanks! I guess the specification is probably a bit unfortunate, since the payload may be much larger than the ccls extension...

Build using LTO if compiler supports it (requires Cmake 3.9)

For clang, we have -flto=full and -flto=thin, and a bunch of other customizable options. Is it simpler delegating CXXFLAGS customization to the user? LTO may have some caveats.

Support the 'reference' codeActionKind

Thanks for working on this. My feeling regarding https://github.com/joaotavora/eglot/issues/302#issuecomment-550225329 is that to make less use of extension methods, it adds some out-of-place round trips. It does reduce the number of...

Caller Hiearchy shows lines of each reference in caller, not start li…

* I remember someone suggested to use the function line instead of the call site for caller hierarchy. It may not be obvious from the UI which functions are the...

can`t not use compile_commands.json with relative path

`src/project.cc Project::loadDirectory`: ```cpp if (g_config->compilationDatabaseCommand.empty()) { cdbDir = root; if (g_config->compilationDatabaseDirectory.size()) { if (sys::path::is_absolute(g_config->compilationDatabaseDirectory)) cdbDir = g_config->compilationDatabaseDirectory; else ////////////// relative compilationDatabaseDirectory is supported sys::path::append(cdbDir, g_config->compilationDatabaseDirectory); } sys::path::append(path, cdbDir, "compile_commands.json"); ```

Fangrui Song