Fangrui Song

Results 147 comments of Fangrui Song

I made a comment about more context https://sourceware.org/bugzilla/show_bug.cgi?id=33577#c34 > GNU ld has used index 0 for unversioned undefined symbols both before version 2.35 (see https://sourceware.org/PR26002 in 2020) and in the...

Say my llvm-project build is at `/tmp/Rel`. `/tmp/Rel/include/llvm/Config/abi-breaking.h` defines `LLVM_ABI_BREAKING_CHECKS`. `llvm/include/llvm/ADT/Hashing.h` includes `abi-breaking.h` and gets the `LLVM_ABI_BREAKING_CHECKS` value from the LLVM build. Whether or not the user build has a...

This needs a test in `oformat-binary.s`. A different `OUTPUT_FORMAT` might change `oFormatBinary` to false.

> > This needs a test in `oformat-binary.s`. A different `OUTPUT_FORMAT` might change `oFormatBinary` to false. > > Okay, I want to write test(s) for this but I'm not sure...

Functions with LR signing gets PACI[AB]SP{,PC}. They have an implicit BTI. If PACI[AB]SP is absent (leaf functions, or when PAuth is not enabled), Clang adds "bti c" to every candidate...

> When doing a :got: and :got_lo12: expression to a local symbol, the GNU and LLVM assemblers convert this to a GOT generating relocation to the section symbol + addend....

Linkers create PT_NOTE program headers from SHT_NOTE sections. There should not be too much concern as in the absence of a dedicated `PT_` program header, rtld can process PT_NOTE. Actually,...