Marvin Wendt

Results 66 issues of Marvin Wendt

Hi, I am using this action on my project [pterm/pterm](https://github.com/pterm/pterm) and today we got a PR that somehow changed my overall coverage for the master branch, even that I haven't...

![image](https://user-images.githubusercontent.com/31022056/178079160-beb7f63d-ca3b-4222-9587-9a4e2ab90340.png)

bug

The BigText printer prints only text. It can use the TextPrinter interface. The `Render()` and `Srender()` methods can be deprecated. We should probably also deprecate the `pterm.LettersFromString` function and the...

proposal
breaking

The `deprecated.go` file contains deprecated functions. The file can be removed safely in a breaking release.

proposal
breaking
proposal-accepted

Make `Theme` more generic and reuse styles more often. `ThemeDefault` -> `ActiveTheme` `ThemeDefault.SuccessMessageStyle` -> `ActiveTheme.SuccessStyle` etc. Also, use primary and secondary style more often in printers.

proposal
breaking
proposal-accepted

This is a breaking issue. Also, PTerm will no longer support go versions below 1.18. This also means, we can upgrade `testza` to the latest version. This change is expected...

proposal
breaking
proposal-accepted

`printer.Stop()` should check if `printer.IsActive` is true, and only stop the printer if it isn't stopped already.

proposal
proposal-accepted

proposal
proposal-accepted