Martin Wittlinger
Martin Wittlinger
# Repairing Code Style Issues ## Non-Protected-Constructor-in-Abstract-Class A non-protected constructor in an abstract class is not needed because only subclasses can be instantiated ## Changes: * Constructor `org.assertj.core.internal.RealNumbers()` is now...
# Repairing Code Style Issues ## PointlessBooleanExpression Boolean expressions shouldn't be overcomplex. # Repairing Code Style Issues * PointlessBooleanExpression (95x) @I-Al-Istannen and I concluded creating a single PR for all...
All violations of this rule are fixed in #4903. I see zero cases where we want code like `.. == true` or `... == false`, so we should stop such...
Like ever enterprise project, the developers make horrible decisions at someday and remove the usability. The Qodana action no longer supports the options we gave it. We need to provide...
# Repairing Code Style Issues ## ToArrayCallWithZeroLengthArrayArgument The performance of the empty array version is the same, and sometimes even better, compared to the pre-sized version. Also, passing a pre-sized...
Currently, we have assertions/testutils in `src/main` instead of `src/test` see https://github.com/INRIA/spoon/tree/master/src/main/java/spoon/testing. Given the java 17 release will be an already breaking major release, I propose to either remove or move...
We somehow have an internal unused package for javadoc, see https://github.com/INRIA/spoon/tree/master/src/main/java/spoon/javadoc/internal. Given we have a new javadoc parser from @I-Al-Istannen we can clean up this for java 17 branch. WDYT?
Currently, spoon has non `@Nullable` annotation and we only document nullablility in the Javadoc. Why don't we adopt https://jspecify.dev/docs/start-here and migrate over the time to an annotated library? An alternative...
Need this for access to repo secrets.