Martin
Martin
Nice, thank you for willingness :) IMO this can be quite a big change, we may need a design for this before coding.
Uploading it into pypi is easy, can be done instantly, but I assume you want to use it as CLI plugin `koji container-build` In this case it will not work,...
sorry I haven't found an quick way how to do it and make it workable, this would require changes to both koji and koji-c codebases.
It seems that koji package doesn't support plugins via entrypoints [1], and I'm not sure how to copy content of this package into another without it. Theoretically we could do...
Or another way could be to copy it just as data_file, but it looks very hackish ```python setup(... data_files=[(os.path.join(sys.prefix,..., 'koji_cli_plugins'), ['plugins/cli_containerbuild.py'])], ... ) ```
@bruno-fs thank you, please fix linter issues and squash fixup commits
What's the status of this PR? Is it pending review or pending changes?
``` 2021-12-21 09:11:59,259 platform:- - atomic_reactor.plugin - DEBUG - running plugin 'import_image' 2021-12-21 09:11:59,259 platform:- - atomic_reactor.plugin - INFO - running plugin instance with args: '{'imagestream': 'registry.fedoraproject.org-python3'}' 2021-12-21 09:11:59,260 -...
Hello, can you please add `sign-off` to your commit? (git commit -s). If somebody reads it :)