Samuel Attard

Results 213 comments of Samuel Attard

So if an iframe opens a child window. `childWindow.webContents.opener` will point to `windowOwningIframe` not the `iframe` itself?

@EricRahm Can you please rebase this PR on latest `main`, there are changes there that should make this PR easier to take (namely the strings are no longer copied into...

Arm32 compilation failures will be fixed by https://chromium-review.googlesource.com/c/linux-syscall-support/+/3786946/

@nojvek The electron package name on NPM has been taken over by the `electron-prebuilt` team. https://www.npmjs.com/package/electron

I still have the code somewhere, I got to the point where I was inferring default values from a repository and was making progress towards automatically making a PR for...

@ameerthehacker I don't think we want to move away from storing everything in a GitHub repo, it allows for versioning/tracking/history we won't get from an S3 bucket. Steps 1-3 I...

@malept You'd have to `pipe` the file as a stream and read the file from the correct offset as your stream encounters it. Super hard to implement correctly and probably...

@chenjunyu19 I'm assuming it has just made an empty ASAR file, I personally don't see an issue here. Semantically it is still accurate because the ASAR file has nothing inside...

This issue is pretty straight forward. Basically lots of apps have an `app.asar` file but they also have an `app.asar.unpacked` folder for some files that shouldn't live in an ASAR....